On Wed, 11 Aug 2021 at 08:40, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Aug 11, 2021 at 12:50:40AM +0100, Phillip Potter wrote: > > Remove unused functions that are now no longer called as a result of the > > removal of rtw_ioctl in a previous patch. This includes functions not > > directly called from rtw_ioctl, but anything in that specific > > call-chain. > > > > Signed-off-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx> > > --- > > drivers/staging/r8188eu/os_dep/ioctl_linux.c | 1538 ++---------------- > > 1 file changed, 127 insertions(+), 1411 deletions(-) > > > > diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c > > index 4e21801cbfcf..1ccc5f8de1ee 100644 > > --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c > > +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c > > @@ -1539,7 +1539,6 @@ static int rtw_wx_get_essid(struct net_device *dev, > > wrqu->essid.length = len; > > wrqu->essid.flags = 1; > > > > -exit: > > This is not a "function", but a label that was not used. > > I'll take this but be more careful next time in the description of > patches as to what they are doing... > > thanks, > > greg k-h Dear Greg, Sorry about that, I had even made a mental note to mention the label explicitly, but it somehow slipped out of my head. I dealt with this in the same patch as it was one of the build warnings I uncovered. Thank you for taking the patches. Regards, Phil
