On Thu, Aug 05, 2021 at 04:50:26PM +0200, Martin Kaiser wrote:
> Compilation fails for me
>
> drivers/staging/r8188eu/hal/rtl8188e_dm.c: In function ‘rtl8188e_HalDmWatchDog’:
> drivers/staging/r8188eu/hal/rtl8188e_dm.c:182:1: error: label at end of compound statement
> 182 | skip_dm:
> | ^~~~~~~
>
> Remove the label at the end of the function. Replace the jump to this label
> with a return statement.
>
> Fixes: b398ff88aa36 ("staging: r8188eu: remove return from void functions")
> Signed-off-by: Martin Kaiser <martin@xxxxxxxxx>
> ---
> v2:
> - add Fixes tag
>
> drivers/staging/r8188eu/hal/rtl8188e_dm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_dm.c b/drivers/staging/r8188eu/hal/rtl8188e_dm.c
> index b5f42127a751..72b3130eddd2 100644
> --- a/drivers/staging/r8188eu/hal/rtl8188e_dm.c
> +++ b/drivers/staging/r8188eu/hal/rtl8188e_dm.c
> @@ -145,7 +145,7 @@ void rtl8188e_HalDmWatchDog(struct adapter *Adapter)
> hw_init_completed = Adapter->hw_init_completed;
>
> if (!hw_init_completed)
> - goto skip_dm;
> + return;
>
> fw_cur_in_ps = Adapter->pwrctrlpriv.bFwCurrentInPSMode;
> rtw_hal_get_hwreg(Adapter, HW_VAR_FWLPS_RF_ON, (u8 *)(&fw_ps_awake));
> @@ -179,7 +179,7 @@ void rtl8188e_HalDmWatchDog(struct adapter *Adapter)
> ODM_CmnInfoUpdate(&hal_data->odmpriv, ODM_CMNINFO_LINK, bLinked);
> ODM_DMWatchdog(&hal_data->odmpriv);
> }
> -skip_dm:
> +
> /* Check GPIO to determine current RF on/off and Pbc status. */
> /* Check Hardware Radio ON/OFF or not */
> }
> --
> 2.20.1
https://lore.kernel.org/r/20210805140941.9130-1-straube.linux@xxxxxxxxx
just submitted the same thing right before you, I'll go add both
signed-off-by as you both did the same thing...
thanks,
greg k-h
