On Wed, Aug 04, 2021 at 01:10:37PM -0500, Larry Finger wrote: > On 8/4/21 10:09 AM, Larry Finger wrote: > > In other Realtek drivers, the while loop has a call to > > rtw_mfree_stainfo(psta). That routine does not exist in this driver, but > > I think it should. In a few rare instances, the driver leaks some memory > > - this missing code may explain that. In any case, this patch should be > > dropped as the fix will require testing. > > After looking at the original code for several other drivers, routine > rtw_mfree_stainfo() just ends up calling a couple of routines that free a > spinlock. That operation for Windows and FreeBSD is not trivial, but for > Linux, the routine does nothing. Thus, despite its name, rtw_mfree_stainfo() > does not free anything, and it can be deleted. > > The original patch is > > Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> Thanks, Larry! Acked-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> regards, dan carpenter
