On Wednesday, August 4, 2021 3:01:36 PM CEST Dan Carpenter wrote: > On Mon, Aug 02, 2021 at 02:55:17AM +0200, Fabio M. De Francesco wrote: > > Remove rtw_mfree_all_stainfo() and the only line of code that calls > > it. This function simply takes a spinlock and iterates over a list > > with no purpose. That iteration has no side effects. > > I mean, it's pretty clearly supposed to free all the items on the list. > Sorry, I'm not sure to understand what you required: since rtw_mfree_all_stainfo() is supposed to free all the nodes on the list, should a better patch *really* delete those items (instead than simply get rid of the function itself)? Thanks, Fabio > > regards, > dan carpenter
