On Wed, Aug 04, 2021 at 01:58:38PM +0300, Dan Carpenter wrote: > On Sat, Jul 31, 2021 at 05:09:38PM +0100, Salah Triki wrote: > > drivers/input/tablet/acecad.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/input/tablet/acecad.c b/drivers/input/tablet/acecad.c > > index a38d1fe97334..85fe134a30ee 100644 > > --- a/drivers/input/tablet/acecad.c > > +++ b/drivers/input/tablet/acecad.c > > @@ -151,7 +151,7 @@ static int usb_acecad_probe(struct usb_interface *intf, const struct usb_device_ > > goto fail2; > > } > > > > - acecad->intf = intf; > > + acecad->intf = usb_get_intf(intf); > > acecad->input = input_dev; > > > > if (dev->manufacturer) > > As I mentioned earlier, you need to drop the reference if > input_register_device() fails. Also as mentioned in other threads, this is not needed at all.
