On Wednesday, August 4, 2021 11:58:39 AM CEST Dan Carpenter wrote: > The patch was based on the faulty premise that the original code was > buggy so I don't think it can be fixed. It just needs to be reverted. > > regards, > dan carpenter With the original code, GCC + sparse emit a dozen of warnings like the following ones: drivers/staging/r8188eu/core/rtw_br_ext.c:693:101: warning: incorrect type in argument 2 (different base types) drivers/staging/r8188eu/core/rtw_br_ext.c:693:101: expected unsigned int *ipxNetAddr drivers/staging/r8188eu/core/rtw_br_ext.c:693:101: got restricted __be32 * drivers/staging/r8188eu/core/rtw_br_ext.c:693:123: warning: incorrect type in argument 3 (different base types) drivers/staging/r8188eu/core/rtw_br_ext.c:693:123: expected unsigned short *ipxSocketAddr drivers/staging/r8188eu/core/rtw_br_ext.c:693:123: got restricted __be16 * drivers/staging/r8188eu/core/rtw_br_ext.c:698:99: warning: incorrect type in argument 2 (different base types) Do we want the above pasted warnings and leave the code as-is? Regards, Fabio
