On Tue, Aug 03, 2021 at 08:20:39AM +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 03, 2021 at 09:14:42AM +0300, Dan Carpenter wrote: > > On Mon, Aug 02, 2021 at 10:30:20PM +0200, Fabio M. De Francesco wrote: > > > IPX_NODE_LEN == 6, while addr.f1 should only have 4 elements. > > > Replace IPX_NODE_LEN with 4. In the while, remove the excess spaces > > > before the fields of the union. > > > > > > Fixes: 56febcc2595e ("staging: r8188eu: Fix different base types in assignments and parameters") > > > > Ugh... I really feel we'd be better off reverting that patch entirely. > > I do too, let me go revert that... Thanks! regards, dan carpenter