Re: [PATCH 2/6] staging: r8188eu: Remove wrapper around vfree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Larry,

I love your patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]
[cannot apply to v5.14-rc3 next-20210730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Larry-Finger/Clean-up-some-extraneous-wrappers-and-some-empty-routines/20210802-231818
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 9b6818c1ac0e545c632265e4bf0aa1171347ebea
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/d0ff5c67cf8341de34bf090ff6b0ef60e60705fd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Larry-Finger/Clean-up-some-extraneous-wrappers-and-some-empty-routines/20210802-231818
        git checkout d0ff5c67cf8341de34bf090ff6b0ef60e60705fd
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/staging/r8188eu/core/rtw_mlme.c: In function '_rtw_free_mlme_priv':
>> drivers/staging/r8188eu/core/rtw_mlme.c:136:3: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
     136 |   vfree(pmlmepriv->free_bss_buf);
         |   ^~~~~
         |   kvfree
   drivers/staging/r8188eu/core/rtw_mlme.c: In function 'rtw_surveydone_event_callback':
   drivers/staging/r8188eu/core/rtw_mlme.c:760:24: warning: variable 'pmlmeext' set but not used [-Wunused-but-set-variable]
     760 |  struct mlme_ext_priv *pmlmeext;
         |                        ^~~~~~~~
   In file included from drivers/staging/r8188eu/core/../include/drv_types.h:25,
                    from drivers/staging/r8188eu/core/rtw_mlme.c:8:
   At top level:
   drivers/staging/r8188eu/core/../include/rtw_security.h:312:28: warning: 'K' defined but not used [-Wunused-const-variable=]
     312 | static const unsigned long K[64] = {
         |                            ^
   cc1: some warnings being treated as errors
--
   drivers/staging/r8188eu/core/rtw_mp.c: In function '_rtw_mp_xmit_priv':
>> drivers/staging/r8188eu/core/rtw_mp.c:925:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
     925 |  vfree(pxmitpriv->pallocated_xmit_extbuf);
         |  ^~~~~
         |  kvfree
   In file included from drivers/staging/r8188eu/core/../include/drv_types.h:25,
                    from drivers/staging/r8188eu/core/rtw_mp.c:6:
   At top level:
   drivers/staging/r8188eu/core/../include/rtw_security.h:312:28: warning: 'K' defined but not used [-Wunused-const-variable=]
     312 | static const unsigned long K[64] = {
         |                            ^
   cc1: some warnings being treated as errors
--
   drivers/staging/r8188eu/core/rtw_recv.c: In function '_rtw_free_recv_priv':
>> drivers/staging/r8188eu/core/rtw_recv.c:118:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
     118 |  vfree(precvpriv->pallocated_frame_buf);
         |  ^~~~~
         |  kvfree
   In file included from drivers/staging/r8188eu/core/../include/drv_types.h:25,
                    from drivers/staging/r8188eu/core/rtw_recv.c:7:
   At top level:
   drivers/staging/r8188eu/core/../include/rtw_security.h:312:28: warning: 'K' defined but not used [-Wunused-const-variable=]
     312 | static const unsigned long K[64] = {
         |                            ^
   cc1: some warnings being treated as errors
--
   drivers/staging/r8188eu/core/rtw_sta_mgt.c: In function 'rtw_mfree_all_stainfo':
   drivers/staging/r8188eu/core/rtw_sta_mgt.c:169:19: warning: variable 'psta' set but not used [-Wunused-but-set-variable]
     169 |  struct sta_info *psta = NULL;
         |                   ^~~~
   drivers/staging/r8188eu/core/rtw_sta_mgt.c: In function '_rtw_free_sta_priv':
>> drivers/staging/r8188eu/core/rtw_sta_mgt.c:236:4: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
     236 |    vfree(pstapriv->pallocated_stainfo_buf);
         |    ^~~~~
         |    kvfree
   In file included from drivers/staging/r8188eu/core/../include/drv_types.h:25,
                    from drivers/staging/r8188eu/core/rtw_sta_mgt.c:7:
   At top level:
   drivers/staging/r8188eu/core/../include/rtw_security.h:312:28: warning: 'K' defined but not used [-Wunused-const-variable=]
     312 | static const unsigned long K[64] = {
         |                            ^
   cc1: some warnings being treated as errors
--
   drivers/staging/r8188eu/core/rtw_xmit.c: In function '_rtw_free_xmit_priv':
>> drivers/staging/r8188eu/core/rtw_xmit.c:255:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
     255 |  vfree(pxmitpriv->pallocated_frame_buf);
         |  ^~~~~
         |  kvfree
   In file included from drivers/staging/r8188eu/core/../include/drv_types.h:25,
                    from drivers/staging/r8188eu/core/rtw_xmit.c:7:
   At top level:
   drivers/staging/r8188eu/core/../include/rtw_security.h:312:28: warning: 'K' defined but not used [-Wunused-const-variable=]
     312 | static const unsigned long K[64] = {
         |                            ^
   cc1: some warnings being treated as errors
--
   drivers/staging/r8188eu/hal/odm_interface.c: In function 'ODM_FreeMemory':
>> drivers/staging/r8188eu/hal/odm_interface.c:88:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
      88 |  vfree(pPtr);
         |  ^~~~~
         |  kvfree
   In file included from drivers/staging/r8188eu/hal/../include/drv_types.h:25,
                    from drivers/staging/r8188eu/hal/../include/odm_precomp.h:14,
                    from drivers/staging/r8188eu/hal/odm_interface.c:4:
   At top level:
   drivers/staging/r8188eu/hal/../include/rtw_security.h:312:28: warning: 'K' defined but not used [-Wunused-const-variable=]
     312 | static const unsigned long K[64] = {
         |                            ^
   cc1: some warnings being treated as errors
--
   drivers/staging/r8188eu/hal/rtl8188e_hal_init.c: In function 'rtw_IOL_cmd_tx_pkt_buf_dump':
>> drivers/staging/r8188eu/hal/rtl8188e_hal_init.c:366:3: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
     366 |   vfree(pbuf);
         |   ^~~~~
         |   kvfree
   In file included from drivers/staging/r8188eu/hal/../include/drv_types.h:25,
                    from drivers/staging/r8188eu/hal/rtl8188e_hal_init.c:7:
   At top level:
   drivers/staging/r8188eu/hal/../include/rtw_security.h:312:28: warning: 'K' defined but not used [-Wunused-const-variable=]
     312 | static const unsigned long K[64] = {
         |                            ^
   cc1: some warnings being treated as errors
--
   drivers/staging/r8188eu/os_dep/ioctl_linux.c: In function 'rtw_wx_set_priv':
>> drivers/staging/r8188eu/os_dep/ioctl_linux.c:5606:3: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
    5606 |   vfree(ext);
         |   ^~~~~
         |   kvfree
   In file included from drivers/staging/r8188eu/os_dep/../include/drv_types.h:25,
                    from drivers/staging/r8188eu/os_dep/ioctl_linux.c:7:
   At top level:
   drivers/staging/r8188eu/os_dep/../include/rtw_security.h:312:28: warning: 'K' defined but not used [-Wunused-const-variable=]
     312 | static const unsigned long K[64] = {
         |                            ^
   cc1: some warnings being treated as errors
--
   drivers/staging/r8188eu/os_dep/usb_intf.c: In function 'rtw_usb_if1_init':
>> drivers/staging/r8188eu/os_dep/usb_intf.c:705:4: error: implicit declaration of function 'vfree'; did you mean 'kfree'? [-Werror=implicit-function-declaration]
     705 |    vfree(padapter);
         |    ^~~~~
         |    kfree
   In file included from drivers/staging/r8188eu/os_dep/../include/drv_types.h:25,
                    from drivers/staging/r8188eu/os_dep/usb_intf.c:8:
   At top level:
   drivers/staging/r8188eu/os_dep/../include/rtw_security.h:312:28: warning: 'K' defined but not used [-Wunused-const-variable=]
     312 | static const unsigned long K[64] = {
         |                            ^
   cc1: some warnings being treated as errors


vim +136 drivers/staging/r8188eu/core/rtw_mlme.c

   130	
   131		rtw_free_mlme_priv_ie_data(pmlmepriv);
   132	
   133		if (pmlmepriv) {
   134			rtw_mfree_mlme_priv_lock (pmlmepriv);
   135	
 > 136			vfree(pmlmepriv->free_bss_buf);
   137		}
   138	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux