On Sun, Aug 01, 2021 at 03:15:52PM -0500, Larry Finger wrote: > On 8/1/21 1:31 AM, Greg Kroah-Hartman wrote: > > > > I am worried that my "remove the wrapper" logic got something wrong > > here, so if you could test the revert of that, I would appreciate it. > > > > I think I need to go buy one of these devices so I can test cleanups > > locally... > > The bad commit was 9ff1cc4ef80e ("staging: r8188eu: remove rtw_buf_free() > function"). > > Looking at it, the only difference between the original wrapper and the new > code is that the wrapper zeros the len variable before the kfree() call, but > making that change did not help. Reverting that patch restores the old > behavior. Ah, doh, that was my fault, sorry, that patch was incorrect (odd git id, don't know where that came from, it's a different id in my tree.) Let me revert this commit and then will redo it correctly. thanks for finding this. > There are lots of these on Ebay from $2.47 up with free shipping! Any hints on the name for how to figure out which devices are supported by this driver? thanks, greg k-h