Hi Phillip, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Phillip-Potter/staging-r8188eu-remove-include-odm_debug-h/20210731-084241 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 9b6818c1ac0e545c632265e4bf0aa1171347ebea config: arc-allyesconfig (attached as .config) compiler: arceb-elf-gcc (GCC) 10.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/14b4d866779af2d7c33114cea6cd2caca9740164 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Phillip-Potter/staging-r8188eu-remove-include-odm_debug-h/20210731-084241 git checkout 14b4d866779af2d7c33114cea6cd2caca9740164 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/staging/r8188eu/hal/HalPhyRf_8188e.c: In function 'phy_PathA_IQK_8188E': >> drivers/staging/r8188eu/hal/HalPhyRf_8188e.c:367:30: warning: variable 'regEA4' set but not used [-Wunused-but-set-variable] 367 | u32 regeac, regE94, regE9C, regEA4; | ^~~~~~ drivers/staging/r8188eu/hal/HalPhyRf_8188e.c: In function 'PHY_IQCalibrate_8188E': >> drivers/staging/r8188eu/hal/HalPhyRf_8188e.c:1094:62: warning: variable 'RegECC' set but not used [-Wunused-but-set-variable] 1094 | s32 RegE94, RegE9C, RegEA4, RegEAC, RegEB4, RegEBC, RegEC4, RegECC; | ^~~~~~ >> drivers/staging/r8188eu/hal/HalPhyRf_8188e.c:1094:30: warning: variable 'RegEAC' set but not used [-Wunused-but-set-variable] 1094 | s32 RegE94, RegE9C, RegEA4, RegEAC, RegEB4, RegEBC, RegEC4, RegECC; | ^~~~~~ In file included from drivers/staging/r8188eu/hal/../include/drv_types.h:25, from drivers/staging/r8188eu/hal/../include/odm_precomp.h:14, from drivers/staging/r8188eu/hal/HalPhyRf_8188e.c:4: At top level: drivers/staging/r8188eu/hal/../include/rtw_security.h:312:28: warning: 'K' defined but not used [-Wunused-const-variable=] 312 | static const unsigned long K[64] = { | ^ vim +/regEA4 +367 drivers/staging/r8188eu/hal/HalPhyRf_8188e.c 8cd574e6af5463af Phillip Potter 2021-07-28 363 8cd574e6af5463af Phillip Potter 2021-07-28 364 static u8 /* bit0 = 1 => Tx OK, bit1 = 1 => Rx OK */ 8cd574e6af5463af Phillip Potter 2021-07-28 365 phy_PathA_IQK_8188E(struct adapter *adapt, bool configPathB) 8cd574e6af5463af Phillip Potter 2021-07-28 366 { 8cd574e6af5463af Phillip Potter 2021-07-28 @367 u32 regeac, regE94, regE9C, regEA4; 8cd574e6af5463af Phillip Potter 2021-07-28 368 u8 result = 0x00; 8cd574e6af5463af Phillip Potter 2021-07-28 369 struct hal_data_8188e *pHalData = GET_HAL_DATA(adapt); 8cd574e6af5463af Phillip Potter 2021-07-28 370 struct odm_dm_struct *dm_odm = &pHalData->odmpriv; 8cd574e6af5463af Phillip Potter 2021-07-28 371 8cd574e6af5463af Phillip Potter 2021-07-28 372 /* 1 Tx IQK */ 8cd574e6af5463af Phillip Potter 2021-07-28 373 /* path-A IQK setting */ 8cd574e6af5463af Phillip Potter 2021-07-28 374 ODM_SetBBReg(dm_odm, rTx_IQK_Tone_A, bMaskDWord, 0x10008c1c); 8cd574e6af5463af Phillip Potter 2021-07-28 375 ODM_SetBBReg(dm_odm, rRx_IQK_Tone_A, bMaskDWord, 0x30008c1c); 8cd574e6af5463af Phillip Potter 2021-07-28 376 ODM_SetBBReg(dm_odm, rTx_IQK_PI_A, bMaskDWord, 0x8214032a); 8cd574e6af5463af Phillip Potter 2021-07-28 377 ODM_SetBBReg(dm_odm, rRx_IQK_PI_A, bMaskDWord, 0x28160000); 8cd574e6af5463af Phillip Potter 2021-07-28 378 8cd574e6af5463af Phillip Potter 2021-07-28 379 /* LO calibration setting */ 8cd574e6af5463af Phillip Potter 2021-07-28 380 ODM_SetBBReg(dm_odm, rIQK_AGC_Rsp, bMaskDWord, 0x00462911); 8cd574e6af5463af Phillip Potter 2021-07-28 381 8cd574e6af5463af Phillip Potter 2021-07-28 382 /* One shot, path A LOK & IQK */ 8cd574e6af5463af Phillip Potter 2021-07-28 383 ODM_SetBBReg(dm_odm, rIQK_AGC_Pts, bMaskDWord, 0xf9000000); 8cd574e6af5463af Phillip Potter 2021-07-28 384 ODM_SetBBReg(dm_odm, rIQK_AGC_Pts, bMaskDWord, 0xf8000000); 8cd574e6af5463af Phillip Potter 2021-07-28 385 8cd574e6af5463af Phillip Potter 2021-07-28 386 /* delay x ms */ 8cd574e6af5463af Phillip Potter 2021-07-28 387 /* PlatformStallExecution(IQK_DELAY_TIME_88E*1000); */ 8cd574e6af5463af Phillip Potter 2021-07-28 388 ODM_delay_ms(IQK_DELAY_TIME_88E); 8cd574e6af5463af Phillip Potter 2021-07-28 389 8cd574e6af5463af Phillip Potter 2021-07-28 390 /* Check failed */ 8cd574e6af5463af Phillip Potter 2021-07-28 391 regeac = ODM_GetBBReg(dm_odm, rRx_Power_After_IQK_A_2, bMaskDWord); 8cd574e6af5463af Phillip Potter 2021-07-28 392 regE94 = ODM_GetBBReg(dm_odm, rTx_Power_Before_IQK_A, bMaskDWord); 8cd574e6af5463af Phillip Potter 2021-07-28 393 regE9C = ODM_GetBBReg(dm_odm, rTx_Power_After_IQK_A, bMaskDWord); 8cd574e6af5463af Phillip Potter 2021-07-28 394 regEA4 = ODM_GetBBReg(dm_odm, rRx_Power_Before_IQK_A_2, bMaskDWord); 8cd574e6af5463af Phillip Potter 2021-07-28 395 8cd574e6af5463af Phillip Potter 2021-07-28 396 if (!(regeac & BIT28) && 8cd574e6af5463af Phillip Potter 2021-07-28 397 (((regE94 & 0x03FF0000)>>16) != 0x142) && 8cd574e6af5463af Phillip Potter 2021-07-28 398 (((regE9C & 0x03FF0000)>>16) != 0x42)) 8cd574e6af5463af Phillip Potter 2021-07-28 399 result |= 0x01; 8cd574e6af5463af Phillip Potter 2021-07-28 400 return result; 8cd574e6af5463af Phillip Potter 2021-07-28 401 } 8cd574e6af5463af Phillip Potter 2021-07-28 402 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
