Use clamp() to simplify odm_evm_db_to_percentage(). Signed-off-by: Michael Straube <straube.linux@xxxxxxxxx> --- When this driver will be moved to drivers/net/wireless/realtek/rtlwifi (if that's the plan?) the odm_evm_db_to_percentage() function could be replaced by the generic version rtl_evm_db_to_percentage() from drivers/net/wireless/realtek/rtlwifi/stats.c drivers/staging/r8188eu/hal/odm_HWConfig.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r8188eu/hal/odm_HWConfig.c index 51ae02805149..19222c0eddf7 100644 --- a/drivers/staging/r8188eu/hal/odm_HWConfig.c +++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c @@ -80,20 +80,11 @@ static u8 odm_SQ_process_patch_RT_CID_819x_Lenovo(struct odm_dm_struct *dm_odm, static u8 odm_evm_db_to_percentage(s8 value) { /* -33dB~0dB to 0%~99% */ - s8 ret_val; - - ret_val = value; - - if (ret_val >= 0) - ret_val = 0; - if (ret_val <= -33) - ret_val = -33; - - ret_val = 0 - ret_val; - ret_val *= 3; + s8 ret_val = clamp(-value, 0, 33) * 3; if (ret_val == 99) ret_val = 100; + return ret_val; } -- 2.32.0