Re: [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 29, 2021 at 03:37:30PM +0200, Martin Kaiser wrote:
> Hi Phil and all,
> 
> Thus wrote Phillip Potter (phil@xxxxxxxxxxxxxxxx):
> 
> > I see what you are saying for sure - I think we've both sunk a fair
> > few patches into the existing driver :-)
> 
> > That said, from what Larry has mentioned, this newer driver would
> > still be a better bet overall due to the additional work that has
> > already happened on it out-of-tree. The Realtek driver you reference
> > probably has no CFG80211 support etc. would be my guess, but I am
> > going off what others have suggested in terms of proposing this
> > patchset. I can't honestly say what the risk of this happening again
> > would be, but minimal I'd imagine.
> 
> ok, understood. That's an important feature. I see that Greg accepted
> your patches, there's no point in arguing any more ;-)
> 
> Greg and Larry: Would you mind sharing your ideas about getting
> rtl8188eu support mainline? Do you imagine that we clean up this driver
> until it can be moved out of staging?

Yes, it's that "simple" :)

> If so, we'd probably have to resolve name conflicts with other realtek
> drivers and rename lots of functions.

Odds are that will happen as the code is cleaned up, right?

> Or would a cleanup of the new rtl8188eu driver be a preparation for
> adding bits and pieces of it to rtlwifi?

Do you think it will fit into that framework?

thanks,

greg k-h




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux