On Wed, 28 Jul 2021 at 19:55, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Jul 28, 2021 at 01:41:15PM -0500, Larry Finger wrote: > > On 7/28/21 1:14 PM, Greg KH wrote: > > > Hm, I thought this would be in better shape than it is. > > > > > > Right now we have 107 .c and .h files in drivers/staging/rtl8188eu/ that > > > come to a total of 44597 lines. > > > > > > So we are taking double the size here? > > > > > > I'm all for putting a "better" driver in here, but this feels odd to > > > me... Is there major new functionality here that is not in the existing > > > driver to justify this? > > > > > > Ok, let's see how this goes, I'll give it a few weeks to see how much > > > can easily be fixed up to hopefully get back to at least close the > > > existing driver size... > > > > The major new functionality is that the new one uses cfg80211, whereas the > > old one uses the WEXT calls. > > Ok, that's worth it alone. > > > It really is an improvement. It just needs a severe cleanup. > > > > I warned you that this code was rough. It took me several weeks to get the > > old one "ready" for staging. I never devoted that effort to the new one, and > > you wanted it in a place where multiple authors could improve it. > > Fair enough, I did ask for it :) > > I'll go through and do a license cleanup tomorrow morning to start with, > that should knock a bunch of lines off right away... > > thanks, > > greg k-h Just stripping the debug code out of this version again will free up quite a few lines I think as well :-) Will get started on that. Regards, Phil
