On Fri, 23 Jul 2021, Lucas Henneman wrote: > This patch resolves checkpatch's warning, "It's generally not useful to > have the filename in the file" for baseband.h. I would paste the exact warning you get from checkpatch.pl, warts (line numbers) and all on a completely separate line. > Signed-off-by: Lucas Henneman <lucas.henneman@xxxxxxxxxx> > --- > drivers/staging/vt6655/baseband.h | 2 -- > 1 file changed, 2 deletions(-) Nice first attempt at working with Mainline Lucas. The premise of the patches seem okay. I don't personally allow filenames into new commits in subsystems I maintain. Seeing as though these patches are *so* trivial, if I were Greg, I'd be asking you to bundle each of these changes into a single patch. > diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h > index 9354ce724446..0a30afaa7cc3 100644 > --- a/drivers/staging/vt6655/baseband.h > +++ b/drivers/staging/vt6655/baseband.h > @@ -3,8 +3,6 @@ > * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. > * All rights reserved. > * > - * File: baseband.h > - * > * Purpose: Implement functions to access baseband > * > * Author: Jerry Chen -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
