Re: [PATCH] staging: rtl8188eu: core: Remove set but unused variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 21, 2021 at 03:35:18PM +0200, Fabio M. De Francesco wrote:
> On Wednesday, July 21, 2021 10:18:34 AM CEST Greg Kroah-Hartman wrote:
> > On Thu, Jul 01, 2021 at 05:46:47PM +0200, Fabio M. De Francesco wrote:
> > > Remove variable sec_idx because is set but unused. Issue detected by
> > > GCC with -Wunused-variable.
> > > 
> > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>
> > > ---
> > > 
> > >  drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > Does not apply to my tree :(
> >
> Your tree changed while my patch was expecting your review. This happened 
> because someone else worked on the same code while 
> "the development tree you have sent a patch for is "closed"
> due to the timing of the merge window".
> 
> Unfortunately,  I was unaware of a similar patch in your queue because I 
> didn't notice that it was sent to the linux-staging list a few days before 
> mine.
> 
> This is not the first time that something like this happens, so I think it's 
> better to not work and send patches while you keep the development tree 
> closed.

The only time it is "closed" is during the merge window.  No need to
stop doing work during then, it's easy to rebase and resend if there are
ever problems.

thanks,

greg k-h




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux