Dear Phillip,
On Tue, Jul 20, 2021 at 11:54:43PM +0100, Phillip Potter wrote:
> On Tue, Jul 20, 2021 at 11:00:36AM +0200, Fabio Aiuto wrote:
> > Hi all,
> >
> > On Mon, Jul 19, 2021 at 06:46:16PM -0500, Larry Finger wrote:
> > > On 7/19/21 5:46 PM, Phillip Potter wrote:
> > > > Move all C source files from the core subdirectory to the root
> > > > folder of the driver, and adjust Makefile accordingly. The ultmate
> > > > goal is to remove hal layer and fold its functionalty into the main
> > > > sources. At this point, the distinction between hal and core will be
> > > > meaningless, so this is the first step towards simplifying the file
> > > > layout.
> > > >
> > > > Signed-off-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>
> > > > ---
> > > > drivers/staging/rtl8188eu/Makefile | 34 +++++++++----------
> > > > drivers/staging/rtl8188eu/{core => }/rtw_ap.c | 0
> > > > .../staging/rtl8188eu/{core => }/rtw_cmd.c | 0
> > > > .../staging/rtl8188eu/{core => }/rtw_efuse.c | 0
> > > > .../rtl8188eu/{core => }/rtw_ieee80211.c | 0
> > > > .../rtl8188eu/{core => }/rtw_ioctl_set.c | 0
> > > > .../staging/rtl8188eu/{core => }/rtw_iol.c | 0
> > >
> > >
> > > I think this is just source churning. The current setup with include. core.
> > > hal and os_dep subdirectories are not opressive.
> > >
> > > Larry
> > >
> > >
> >
> > maybe the information we will need one day is:
> >
> > will the core/-os_dep/-hal/-include/-directory-structure be
> > welcomed in mainline wireless subsystem, when an rtl* driver
> > will be perfectly tuned?
> >
> > At the moment I can't see such a directory organization
> > in any of the realtek wireless driver.
> >
> > Sure there's time for that ;),
> >
> > Thank you,
> >
> > fabio
> >
> >
> Dear Fabio,
>
> Certainly a good start is removing this 'hal' layer so for now I'll
> focus on that as much as I can. Perhaps the path forwards will become
> clearer without it there :-) Thank you for your feedback.
Agreed
>
> Regards,
> Phil
thank you,
fabio
