Hello Dan, On Mon, Jul 05, 2021 at 12:56:09PM +0300, Dan Carpenter wrote: > Hi Ojaswin, > > url: https://github.com/0day-ci/linux/commits/Ojaswin-Mujoo/vchiq-Patch-to-separate-platform-and-cdev-code/20210705-000124 > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 77ad1f0e99bd00af024e650b862cfda3137af660 > config: i386-randconfig-m021-20210705 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > smatch warnings: > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c:1235 vchiq_release() warn: argument 3 to %lx specifier is cast from pointer > > vim +1235 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c > > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1227 static int vchiq_release(struct inode *inode, struct file *file) > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1228 { > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1229 struct vchiq_instance *instance = file->private_data; > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1230 struct vchiq_state *state = vchiq_get_state(); > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1231 struct vchiq_service *service; > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1232 int ret = 0; > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1233 int i; > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1234 > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 @1235 vchiq_log_info(vchiq_arm_log_level, "%s: instance=%lx", __func__, > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1236 (unsigned long)instance); > > This should eventually be converted to %p so it doesn't defeat KASLR. > (Not that we really care on raspberry pi, I think?) Yes, that does seem right, however, this patchset only moves the code from vchiq_arm.c to vchiq_dev.c and I've not really touched any of the existing code itself (Except moving it to a new file which is why it shows up in the patch). Hence, I'm not sure if this fix is in scope of this patchset. (I also have a similar warning by kernel test robot here [1] which and I'm not sure if I need to act upon). Maybe we can look at this in a separate patch? [1] https://lkml.org/lkml/2021/7/4/138 > > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1237 > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1238 if (!state) { > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1239 ret = -EPERM; > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1240 goto out; > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1241 } > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1242 > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1243 /* Ensure videocore is awake to allow termination. */ > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1244 vchiq_use_internal(instance->state, NULL, USE_TYPE_VCHIQ); > 62b5eb4fdf3f5f Ojaswin Mujoo 2021-07-04 1245 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx > Thank you for looking into this, Ojaswin
