Re: [PATCH] staging: rtl8188eu: Remove an unused variable and some lines of code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Fabio M. De Francesco" <fmdefrancesco@xxxxxxxxx>
Subject: Re: [PATCH] staging: rtl8188eu: Remove an unused variable and some lines of code
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Fri, 2 Jul 2021 15:46:06 +0300
Cc: Larry Finger <Larry.Finger@xxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, linux-staging@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20210702124225.GW2040@kadam>
References: <20210701144707.22820-1-fmdefrancesco@gmail.com> <20210702074840.GT2040@kadam> <20210702083521.GV2040@kadam> <2153683.Tj7f0gbxMR@linux.local> <20210702124225.GW2040@kadam>
User-agent: Mutt/1.9.4 (2018-02-28)

You should write that at the start of the commit message.

This driver doesn't support SIOCSIWRATE.  It just returns zero and does
nothing.  Change it to return -ENOTSUPP instead.  (This is an API change
but we don't expect it to break anything).

regards,
dan carpenter

References:
- [PATCH] staging: rtl8188eu: Remove an unused variable and some lines of code
  - From: Fabio M. De Francesco
- Re: [PATCH] staging: rtl8188eu: Remove an unused variable and some lines of code
  - From: Dan Carpenter
- Re: [PATCH] staging: rtl8188eu: Remove an unused variable and some lines of code
  - From: Dan Carpenter
- Re: [PATCH] staging: rtl8188eu: Remove an unused variable and some lines of code
  - From: Fabio M. De Francesco
- Re: [PATCH] staging: rtl8188eu: Remove an unused variable and some lines of code
  - From: Dan Carpenter

Prev by Date: Re: [PATCH v11 4/8] staging: hi6421-spmi-pmic: cleanup drvdata
Next by Date: staging: rtl8712: dead code on flush_signals_thread call in r8712_cmd_thread()
Previous by thread: Re: [PATCH] staging: rtl8188eu: Remove an unused variable and some lines of code
Next by thread: [PATCH] staging: rtl8188eu: core: Remove set but unused variable
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]