Looks good. I feel like the kbuild warnings could be addressed in later patches. It seems as if some of the error handling in this driver is "pretend to print an error message (but it's actually dead code)". Which is probably not the correct way to handle errors... :/ But that's not something introduced by this patch. Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> regards, dan carpenter
