On Thu, Jun 24, 2021 at 05:43:22PM +0200, Mauro Carvalho Chehab wrote: > Em Thu, 24 Jun 2021 16:26:41 +0200 > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> escreveu: > > > On Thu, Jun 24, 2021 at 04:01:32PM +0200, Mauro Carvalho Chehab wrote: > > > Before moving this driver out of staging, do a couple of > > > cleanups, in order to make the driver clearer. > > > > > > No functional changes. > > > > > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> > > > --- > > > drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 122 ++++++++++-------- > > > .../hikey9xx/hisilicon,hi6421-spmi-pmic.yaml | 7 +- > > > 2 files changed, 71 insertions(+), 58 deletions(-) > > > > > > diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c > > > index 626140cb96f2..252b731e272d 100644 > > > --- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c > > > +++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c > > > @@ -2,9 +2,9 @@ > > > /* > > > * Device driver for regulators in HISI PMIC IC > > > * > > > - * Copyright (c) 2013 Linaro Ltd. > > > - * Copyright (c) 2011 Hisilicon. > > > - * Copyright (c) 2020-2021 Huawei Technologies Co., Ltd > > > + * Copyright (c) 2013- Linaro Ltd. > > > + * Copyright (c) 2011- Hisilicon. > > > > What does the "-" mean here? That does not mean from 2013-present. > > I'm pretty sure I found some copyright notes using this convention > somewhere to mean "2013-present". That is not a valid copyright date assignment listing. There is no way to say something like this as it does not make any sense. The years need to be listed individually or as a range. thanks, greg k-h