Hello Dan, On Mon, Jun 21, 2021 at 11:21:32AM +0300, Dan Carpenter wrote: > On Sun, Jun 20, 2021 at 06:25:46PM +0530, Ojaswin Mujoo wrote: > > vchiq_debugfs_init(); > > > > vchiq_log_info(vchiq_arm_log_level, > > - "vchiq: initialised - version %d (min %d), device %d.%d", > > - VCHIQ_VERSION, VCHIQ_VERSION_MIN, > > - MAJOR(vchiq_devid), MINOR(vchiq_devid)); > > + "vchiq: platform initialised - version %d (min %d)", > > + VCHIQ_VERSION, VCHIQ_VERSION_MIN); > > + > > + /* > > + * We don't handle error here since the function handles > > + * cleanup in cases of failure. Further, we can proceed > > + * even if this function fails. > > + */ > > + vchiq_register_chrdev(&pdev->dev); > > I feel like ignoring errors and just continuing seems helpful, but it's > actually doing the users a disservice. If it's an error during, boot > that's different, in that case it's better to get some kind of minimally > useful boot so the user can debug the problem. But if the error isn't > going to prevent the system from booting then it's better to just return > an error so they can fix the problem and try again. Got it, I'll fix this in the next revision. Thank you, Ojaswin > > regards, > dan carpenter >
