On Tue, Jun 15, 2021 at 01:14:42AM +0100, Phillip Potter wrote: > @@ -4510,8 +4311,7 @@ void mlmeext_joinbss_event_callback(struct adapter *padapter, int join_res) > rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_CONNECT, 0); > > exit_mlmeext_joinbss_event_callback: > - > - DBG_88E("=>%s\n", __func__); > + return; > } You'll have to delete the return and the exit_mlmeext_joinbss_event_callback label in a follow on patch because it introduces a checkpatch warning. (I'm not concerned about introducing checkpatch warnings in this patch too much because fixing them in one got makes the patch a little more complicated to review. So it's not necessarily even a wrong thing to introduce a checkpatch warning. Just remember to remove it later. Or don't remember because eventually someone else will take care of it). regards, dan carpenter > > void mlmeext_sta_add_event_callback(struct adapter *padapter, struct sta_info *psta)