Re: [PATCH 0/6] staging: rtl8188eu: remove hal/odm_debug.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thus wrote Dan Carpenter (dan.carpenter@xxxxxxxxxx):

> On Fri, Jun 11, 2021 at 01:24:58AM +0100, Phillip Potter wrote:
> > This series removes hal/odm_debug.h, which contains various preprocessor
> > definitions, as well as an unwieldy ODM_RT_TRACE macro which is not best
> > practice. It also removes all uses of this macro, and the associated
> > fields in struct odm_dm_struct which are only used by this macro.

> > This makes the code cleaner, thus moving it closer to getting out of
> > staging.

> Looks good.

> Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

same here: looks ok and doesn't break anything

Reviewed-by: Martin Kaiser <martin@xxxxxxxxx>
Tested-by: Martin Kaiser <martin@xxxxxxxxx>

Best regards,

   Martin




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux