On Wed, Jun 09, 2021 at 12:21:06PM +0300, Dan Carpenter wrote: > On Wed, Jun 09, 2021 at 12:56:09AM +0100, Phillip Potter wrote: > > Within rtl88eu_dm_txpower_track_adjust function, retrieve the struct > > net_device pointer, and replace both calls to the ODM_RT_TRACE macro > > with equivalent netdev_dbg calls, as well as modifying layout, wording > > and spacing slightly. The purpose of this, and patches like it, is to > > eventually remove the need for include/odm_debug.h, which is an overly > > complex way of printing debug/tracing information about the driver. > > > > In the original code DebugComponents is always zero so the ODM_RT_TRACE() > stuff was dead code and could never be printed. I would prefer we just > delete it all instead of fixing it. > > regards, > dan carpenter > Dear Dan (and Greg), Thank you for your feedback. I will just remove all the ODM_RT_TRACE calls in a follow up patch set in that case. Regards, Phil
