Hi, On 6/5/21 2:54 AM, Guenter Roeck wrote: > On Fri, Jun 04, 2021 at 07:26:33PM +0200, Fabio Aiuto wrote: >> Hello Guenter, >> >> On Wed, Apr 28, 2021 at 10:33:01AM -0700, Guenter Roeck wrote: >>> The rtl8723bs driver manually re-implements list helper functions >>> and macros in various ways. Replace with existing list helpers. >> >> I'm testing rtl8723bs on a baytrail tablet (Lenovo Ideapad MIIX 300-10IBY) >> and applying the tag staging-5.13-rc4, loading r8723bs makes the whole >> system freezing while trying to connect to local AP. >> >> Only a power off is allowed. >> >> I found that commit b3cd518c5abd42fbc747ef55a5fdc40bf7bf01c0 >> (staging: rtl8723bs: Use list iterators and helpers) >> introduced the bug. >> >> I'm trying to find out what's wrong with this patch, have you any suggestions? > > Some of the iterators needed the _safe variant which I didn't take into account. > I thought that was fixed, but maybe some locations were missed. Since 5.13 is already at rc5 now, maybe we should revert this and try again later ? Regards, Hans