Re: [PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2 Jun 2021 at 22:45, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Jun 02, 2021 at 09:33:31PM +0530, Manikishan Ghantasala wrote:
> > staging: rtl8192u: r8192U_hw.h: Clear the coding-style issue
>
> Why is this line here?
>
Added it as description and I put a break due to char limit.
> >
> > "Macros with complex values should be enclosed in parentheses"
> > by enclosing values in parantheses.
>
> I can not understand this sentence, can you please reword it?
>
I meant, I cleared(fixed) the error in quotes by enclosing them in parentheses.

> > Modified spacing around "|" and removed a space before tab.
>
> This is not related to the first thing, please break this up into
> multiple patches like the bot asked...
>
Okay, will do. Do I have to make one for the 'space before tab' too?
or can I ignore it?
> thanks,
>
> greg k-h


Thanks,
Manikishan Ghantasala




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux