Re: [PATCH] staging: rtl8723bs: remove the repeated declaration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

On 2021/5/26 0:21, Greg Kroah-Hartman wrote:
> On Tue, May 25, 2021 at 02:18:51PM +0800, Shaokun Zhang wrote:
>> Function 'Hal_SetBandwidth' is declared twice, remove the
>> repeated declaration.
>>
>> Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
>> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Shaokun Zhang <zhangshaokun@xxxxxxxxxxxxx>
>> ---
>>  drivers/staging/rtl8723bs/include/rtw_mp.h | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/include/rtw_mp.h b/drivers/staging/rtl8723bs/include/rtw_mp.h
>> index 2788ad80b114..ea3abee325ef 100644
>> --- a/drivers/staging/rtl8723bs/include/rtw_mp.h
>> +++ b/drivers/staging/rtl8723bs/include/rtw_mp.h
>> @@ -348,7 +348,6 @@ void Hal_SetCarrierSuppressionTx(struct adapter *padapter, u8 bStart);
>>  void Hal_SetSingleToneTx(struct adapter *padapter, u8 bStart);
>>  void Hal_SetSingleCarrierTx(struct adapter *padapter, u8 bStart);
>>  void Hal_SetContinuousTx(struct adapter *padapter, u8 bStart);
>> -void Hal_SetBandwidth(struct adapter *padapter);
>>  
>>  void Hal_SetDataRate(struct adapter *padapter);
>>  void Hal_SetChannel(struct adapter *padapter);
>> -- 
>> 2.7.4
>>
>>
> 
> You sent 2 patches with identical subjects, yet they did different
> things :(
> 

Oops, my apologies that I didn't check it carefully.

> Please fix up and send a patch series that properly identifies what is

Since both are the trivial patch on rtl8723bs, shall I do a single patch
to cleanup this?

Thanks,
Shaokun

> happening here.
> 
> thanks,
> 
> greg k-h
> .
> 




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux