On Sat, May 22, 2021 at 11:26:50AM +0200, Greg KH wrote: > On Sat, May 22, 2021 at 02:50:23PM +0530, Shreyansh Chouhan wrote: > > Reduce the number of indents in rtw_wlan_util.c file by refactoring the > > code. > > > > Moved the part of code that rearranged ac paramaters in the function > > WMMOnAssocResp to a separate function named sort_wmm_ac_params. It takes > > both the array of ac params and their indexes as arguments and sorts them. > > Has return type void. > > > > Moved the part of code that checked for the realtek vendor in the > > function check_assoc_AP to a separate function named > > get_realtek_assoc_AP_vender. It takes a pointer to struct > > ndis_80211_var_ie as an argument and returns a u32 realtek vendor. > > > > Signed-off-by: Shreyansh Chouhan <chouhan.shreyansh630@xxxxxxxxx> > > --- > > .../staging/rtl8723bs/core/rtw_wlan_util.c | 108 +++++++++--------- > > 1 file changed, 56 insertions(+), 52 deletions(-) > > Why is [RFC] in the subject line? Do you not want these merged? > No, since I wanted to ask about the names of these functions I sent these patches as RFC. If these names are fine, I'll send another patch series with a couple of patches besides these that fix other much simpler coding style issues in the same file. > confused, > I hope this clears the confusion caused. > greg k-h thanks, --Shreyansh
