Re: [PATCH 5/6] comedi: drivers: ni_mio_common: Move 'range_ni_E_ao_ext' to where it is used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Subject: Re: [PATCH 5/6] comedi: drivers: ni_mio_common: Move 'range_ni_E_ao_ext' to where it is used
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Fri, 21 May 2021 19:25:54 +0300
Cc: Lee Jones <lee.jones@xxxxxxxxxx>, Ian Abbott <abbotti@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Thierry Reding <thierry.reding@xxxxxxxxx>, "David A. Schleef" <ds@xxxxxxxxxxx>, Mori Hess <fmhess@xxxxxxxxxxxxxxxxxxxxx>, Truxton Fulton <trux@xxxxxxxxxxxxxxxxxxx>, linux-staging@xxxxxxxxxxxxxxx, linux-pwm@xxxxxxxxxxxxxxx
In-reply-to: <20210521143925.xjmwluaoyer322lg@pengutronix.de>
References: <20210520122538.3470259-1-lee.jones@linaro.org> <20210520122538.3470259-6-lee.jones@linaro.org> <c69d39a0-bf9e-857d-93ba-73e2884fa4ad@mev.co.uk> <20210521072635.GY2549456@dell> <20210521115431.GK1955@kadam> <20210521143925.xjmwluaoyer322lg@pengutronix.de>
User-agent: Mutt/1.9.4 (2018-02-28)

On Fri, May 21, 2021 at 04:39:25PM +0200, Uwe Kleine-König wrote:
> 
> and it built for me.

You're right.  I appologize.  I thought the linker would fail if we
had the same variable in two files but I was wrong.

regards,
dan carpenter

References:
- [PATCH 0/6] Rid W=1 warnings from Comedi
  - From: Lee Jones
- [PATCH 5/6] comedi: drivers: ni_mio_common: Move 'range_ni_E_ao_ext' to where it is used
  - From: Lee Jones
- Re: [PATCH 5/6] comedi: drivers: ni_mio_common: Move 'range_ni_E_ao_ext' to where it is used
  - From: Ian Abbott
- Re: [PATCH 5/6] comedi: drivers: ni_mio_common: Move 'range_ni_E_ao_ext' to where it is used
  - From: Lee Jones
- Re: [PATCH 5/6] comedi: drivers: ni_mio_common: Move 'range_ni_E_ao_ext' to where it is used
  - From: Dan Carpenter
- Re: [PATCH 5/6] comedi: drivers: ni_mio_common: Move 'range_ni_E_ao_ext' to where it is used
  - From: Uwe Kleine-König

Prev by Date: [PATCH v2] staging: rtl8712: Fix memory leak in r8712_init_recv_priv
Next by Date: Re: [PATCH v2] staging: rtl8712: Fix memory leak in r8712_init_recv_priv
Previous by thread: Re: [PATCH 5/6] comedi: drivers: ni_mio_common: Move 'range_ni_E_ao_ext' to where it is used
Next by thread: [PATCH 4/6] comedi: drivers: ni_routes: Demote non-conforming kernel-doc headers
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]