On Wed, May 19, 2021 at 01:19:58AM -0700, Hriday Hegde wrote:
> Fixing following warnings found by checkpatch.pl
> WARNING: struct file_operations should normally be const
> 380: FILE: drivers/staging/android/ashmem.c:380:
> + static struct file_operations vmfile_fops;
>
> Signed-off-by: Hriday Hegde <hridayhegde1999@xxxxxxxxx>
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 8ee4320a5dc6..8ff2794b08e3 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>
> static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
> {
> - static struct file_operations vmfile_fops;
> + static const struct file_operations vmfile_fops;
> struct ashmem_area *asma = file->private_data;
> int ret = 0;
>
> --
> 2.25.1
>
>
Any reason why you didn't build your change before submitting this
patch?
thanks,
greg k-h
