On Tue, May 18, 2021 at 07:48:34PM +0800, Wang Qing wrote: > fixing WARNING: void function return statements are not generally useful > > Signed-off-by: Wang Qing <wangqing@xxxxxxxx> > --- > drivers/staging/greybus/audio_codec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c > index b589cf6..ffd8997 > --- a/drivers/staging/greybus/audio_codec.c > +++ b/drivers/staging/greybus/audio_codec.c > @@ -1028,7 +1028,6 @@ static int gbcodec_probe(struct snd_soc_component *comp) > static void gbcodec_remove(struct snd_soc_component *comp) > { > /* Empty function for now */ > - return; > } This is called from snd_soc_component_remove(). Just delete the whole function. It's unclear why there are so many dummy functions in this driver... regards, dan carpenter