On Fri, May 14, 2021 at 10:38:57AM +0200, Fabio Aiuto wrote: > Hello all, > > I'd like to have some clarifications about rtl8723bs driver. > In order to make this driver ready for moving out of staging > I would like to know: > > - find and remove remaining code valid only for 5 GHz. Most of the obvious > ones have been removed, but things like channel > 14 still exist. > > is it possible to remove all 5g code, even the one related to power > regulation when on band 5g? As far as I know about this card is that > it doesn't support 5g, so may I just delete all 5g code or there are some > constraints I'd take care of? > > - find and remove any code for other chips that is left over > > Ok this seems clear, are there some suggestion to do it safely? > > - convert any remaining unusual variable types > > Ok (but feel free to suggest anything) > > - find codes that can use %pM and %Nph formatting > > Ok (but feel free to suggest anything) > > - checkpatch.pl fixes - most of the remaining ones are lines too long. Many > of them will require refactoring > > Ok > > - merge Realtek's bugfixes and new features into the driver > > Please, can you explain what one could do that? > > - switch to use LIB80211 > - switch to use MAC80211 > > I think I need a few details for these last points as well. > > Do you think that one will need real hardware to complete > these tasks? I don't have rtl8723bs card at the moment, so > I think I will focus on those TODO activities which > don't need it. I recommend getting one of these devices to do the more complex tasks as described above. Otherwise it's going to be hard to verify that your changes are valid. thanks, greg k-h
