Re: [PATCH 2/2] staging: rtl8723bs: core: eliminate erroneous reporting of unused variable 'evt_seq'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 13, 2021 at 05:40:07PM +0800, Zhen Lei wrote:
> GCC reports the following warning with W=1:
> 
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:6003:15: warning:
>  variable ‘evt_seq’ set but not used [-Wunused-but-set-variable]
>  6030 |  u8 evt_code, evt_seq;
>       |               ^~~~~~~
> 
> The local variable ‘evt_seq’ is referenced only when the macro
> CHECK_EVENT_SEQ is defined, move its definition and assignment into the
> control scope of macro CHECK_EVENT_SEQ, to fix the warning.
> 
> By the way, clear local coding style warnings and delete several redundant
> blank lines.

Do not do lots of different things in the same patch, this should be
broken up into doing "one logical thing per change".

Please fix up and send as a series.

thanks,

greg k-h




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux