RE: [PATCH v2 1/2] staging: rtl8723bs: replace private CRC-32 routines with in-kernel ones

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "'Fabio Aiuto'" <fabioaiuto83@xxxxxxxxx>, "gregkh@xxxxxxxxxxxxxxxxxxx" <gregkh@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [PATCH v2 1/2] staging: rtl8723bs: replace private CRC-32 routines with in-kernel ones
From: David Laight <David.Laight@xxxxxxxxxx>
Date: Mon, 10 May 2021 13:38:49 +0000
Cc: "linux-staging@xxxxxxxxxxxxxxx" <linux-staging@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <cdd9bc521b7119a9c2787b46109eb76f94bd295a.1620652505.git.fabioaiuto83@gmail.com>
References: <cover.1620652505.git.fabioaiuto83@gmail.com> <cdd9bc521b7119a9c2787b46109eb76f94bd295a.1620652505.git.fabioaiuto83@gmail.com>

> replace private CRC-32 routines with in-kernel ones.

Have you verified that they compute the same CRC?

There are all sorts of subtle reasons why the outputs can differ.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

Follow-Ups:
- Re: [PATCH v2 1/2] staging: rtl8723bs: replace private CRC-32 routines with in-kernel ones
  - From: Fabio Aiuto
- Re: [PATCH v2 1/2] staging: rtl8723bs: replace private CRC-32 routines with in-kernel ones
  - From: Fabio Aiuto

References:
- [PATCH v2 0/2] staging: rtl8723bs: use of generic CRC-32
  - From: Fabio Aiuto
- [PATCH v2 1/2] staging: rtl8723bs: replace private CRC-32 routines with in-kernel ones
  - From: Fabio Aiuto

Prev by Date: [PATCH v2 2/2] staging: rtl8723bs: remove unneeded comments to silence 'line too long' warning
Next by Date: Re: [PATCH v2 1/2] staging: rtl8723bs: replace private CRC-32 routines with in-kernel ones
Previous by thread: [PATCH v2 1/2] staging: rtl8723bs: replace private CRC-32 routines with in-kernel ones
Next by thread: Re: [PATCH v2 1/2] staging: rtl8723bs: replace private CRC-32 routines with in-kernel ones
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]