Re: [PATCH 2/2] staging: fieldbus: anybus: Refuse registering drivers without .probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Uwe,

On Thu, May 6, 2021 at 2:17 AM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
>
> So sorry, I have no motivation to support getting this out of staging.

No worries, this subsystem would only be useful to you, if you were
running Linux on a Fieldbus client device. That is still quite niche -
on mainline.

>
> BTW: I just noticed there are occurences of anybuss and anybus in the
> driver. Is only one of them right?

There are various "flavours" of Anybus. One of them is Anybus-S, which
is the one implemented here. Support could be added for the other
flavours, but there is no use case right now. The reason why I went
with "anybuss_xxx" instead of "anybus_s_xxx" was purely visual. Code
such as this:

> void anybus_s_client_driver_unregister(struct anybuss_client_driver *drv)

looked really bad to me. Perhaps in hindsight, "anybus_s_xxx" would
have been the better choice, because quite a few people have
questioned the double-S. But hindsight is 20/20, and there is no good
incentive to change it now, except if Anybus-S suddenly became more
popular. Which is unlikely, it's now purely a legacy bus.





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux