On Tue, May 04, 2021 at 04:38:11PM +0200, Fabio M. De Francesco wrote: > > As far as (1) and (2) are regarded, I've been told that when one modifies code > she/he should not diverge from the style of the subsystem/driver maintainer/ > author. If you look at visorhba_main.c, you'll find a lot of unnecessary > 'else' and 'if (success)'... > > So what are the general rules one should follow when changing (trivial) Linux > code? Please note that my question has no other (hidden) purposes than > learning to work properly with the Linux community and to reduce the > unnecessary noise consequential to submitting a high number of patch versions. "trivial" changes should only be done in subsystems that welcome it. drivers/staging/ welcomes it, anything other than that, you need to ask the maintainer. thanks, greg k-h
