Re: [PATCH v3 02/43] staging: rtl8723bs: remove if-else blocks left empty by ODM_RT_TRACE deletion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 30, 2021 at 04:56:24PM +0200, Fabio Aiuto wrote:
> @@ -1533,13 +1529,10 @@ static void phy_IQCalibrate_8723B(
>  				result[t][6] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQK_A_2, bMaskDWord)&0x3FF0000)>>16;
>  				result[t][7] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_After_IQK_A_2, bMaskDWord)&0x3FF0000)>>16;
>  				break;
> -			} else {
>  			}
>  		}
>  
>  /* Allen end */

This comment doesn't mean anything.  It feels like it was supposed to
go with the code that you deleted so it should have been deleted as part
of deleting the empty block.  But it's fine to me if you delete it in
a later patch.

> -		if (0x00 == PathBOK) {
> -		}
>  	}
>  
>  	/* Back to BB mode, load original value */

regards,
dan carpenter





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux