Re: [PATCH v2 00/50] staging: rtl8723bs: remove all remaining debug macros in rtw_debug.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 27, 2021 at 01:06:23PM +0200, Greg KH wrote:
> On Sat, Apr 24, 2021 at 11:01:43AM +0200, Fabio Aiuto wrote:
> > This patchset removes all remaining debug macros in rtw_debug.h
> > 
> > DBG_871X_SEL macro is replaced with netdev_dbg() for it does
> > a raw printk call which is not best recommended for a driver.
> > 
> > @@
> > expression sel;
> > expression list args;
> > identifier padapter;
> > identifier func;
> > @@
> > 
> > func(..., struct adapter *padapter, ...) {
> >         <...
> > -       DBG_871X_SEL(sel, args);
> > +       netdev_dbg(padapter->pnetdev, args);
> >         ...>
> > 
> > unused _DBG_871X_LEVEL macro declaration is removed.
> > 
> > Beautified register dump in core/rtw_debug.c 
> > 
> > Some code cleaning is done and all other private component tracing
> > macros are removed.
> 
> Nice work, thanks for doing all of this!  Now queued up for 5.14-rc1.
> 
> greg k-h

thank you all for helping me,

fabio




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux