On Tue, 2021-04-27 at 11:03 +0200, Greg KH wrote: > > There's another call to register_netdevice() here but I don't think > > that's affected, however, it's obviously utterly broken in the first > > place: > > > > if (!rtnl_is_locked()) > > unregister_netdev(cur_pnetdev); > > else > > unregister_netdevice(cur_pnetdev); > > > > *sigh*. > > Sorry, these staging wireless drivers are really getting annoying. > Maybe I need to turn an intern onto them to just get them fixed up and > out of here to be a 'real' driver. :) FWIW, in this case it looks like it's actually not even incorrect, because it's guaranteed to already hold the RTNL *itself*. Just all that code can be removed. johannes
