Am 23.04.21 um 09:23 schrieb Fabio Aiuto: > On Thu, Apr 22, 2021 at 10:07:49PM +0200, Stefan Wahren wrote: >> Nesting multiple ternary operators over multiple lines isn't easy to >> read. Move this logic into a separate inline function. >> >> Signed-off-by: Stefan Wahren <stefan.wahren@xxxxxxxx> >> --- >> .../vc04_services/interface/vchiq_arm/vchiq_core.c | 35 ++++++++++++++-------- >> 1 file changed, 22 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c >> index 8a1e6f5..3a72c36 100644 >> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c >> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c >> @@ -2622,9 +2630,10 @@ do_abort_bulks(struct vchiq_service *service) >> mutex_unlock(&service->bulk_mutex); >> >> status = notify_bulks(service, &service->bulk_tx, 0/*!retry_poll*/); >> - if (status == VCHIQ_SUCCESS) >> - status = notify_bulks(service, &service->bulk_rx, >> - 0/*!retry_poll*/); >> + if (status != VCHIQ_SUCCESS) >> + return 0; >> + >> + status = notify_bulks(service, &service->bulk_rx, 0/*!retry_poll*/); >> return (status == VCHIQ_SUCCESS); >> } > Hi Stefan, > > this change seem to be unrelated ti what's pointed out in changelog. > Should it be put in a separate patch? Oops, yes this should be a separate patch. > >> >> -- >> 2.7.4 >> >> > thank you, > > fabio
