On Thu, 2021-04-22 at 22:07 +0200, Stefan Wahren wrote:
> Replace the custom set of return values with proper Linux error codes for
> vchiq_set_service_option(). Now we can use the result directly as return
> value for vchiq_ioctl().
>
> Signed-off-by: Stefan Wahren <stefan.wahren@xxxxxxxx>
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++--
> .../vc04_services/interface/vchiq_arm/vchiq_core.c | 18 +++++++++---------
> .../vc04_services/interface/vchiq_arm/vchiq_core.h | 2 +-
> 3 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> index 3395201..ab2ce07 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> @@ -1517,8 +1517,8 @@ vchiq_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> break;
> }
>
>
> - status = vchiq_set_service_option(
> - args.handle, args.option, args.value);
> + ret = vchiq_set_service_option(args.handle, args.option,
> + args.value);
> } break;
>
>
> case VCHIQ_IOC_LIB_VERSION: {
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> index 9f9677a..31c1c1a 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> @@ -3371,21 +3371,21 @@ void vchiq_get_config(struct vchiq_config *config)
> config->version_min = VCHIQ_VERSION_MIN;
> }
>
>
> -enum vchiq_status
> +int
> vchiq_set_service_option(unsigned int handle,
> enum vchiq_service_option option, int value)
> {
> struct vchiq_service *service = find_service_by_handle(handle);
> - enum vchiq_status status = VCHIQ_ERROR;
> struct vchiq_service_quota *quota;
> + int ret = -EIO;
Due to the nature of the driver it's hard to make a clear distinction, but is
-EIO really the best error for the function? I don't see error paths that
really depend on communication with VC4. I see it more aligned with -EINVAL.
Regards,
Nicolas
