On Sun, Apr 18, 2021 at 08:13:23PM +0530, Saurav Girepunje wrote:
> Fix the following coccicheck warning:
>
> drivers/staging/media/atomisp/pci/sh_css_mipi.c:39:5-8:
> Unneeded variable: "err". Return "0" on line 44
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@xxxxxxxxxx>
> ---
> drivers/staging/media/atomisp/pci/sh_css_mipi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_mipi.c b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> index d5ae7f0b5864..708903a31b08 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> @@ -36,12 +36,11 @@ ref_count_mipi_allocation[N_CSI_PORTS]; /* Initialized in mipi_init */
> int
> ia_css_mipi_frame_specify(const unsigned int size_mem_words,
> const bool contiguous) {
> - int err = 0;
>
> my_css.size_mem_words = size_mem_words;
> (void)contiguous;
>
> - return err;
> + return 0;
> }
>
> /*
> --
> 2.25.1
>
>
Hi Saurav,
this ia_css_mipi_frame_specify seems to be unused. On
header file, before the prototype it is said that it could
be removed only when all drivers moved to a new API.
Is that comment obsolete?
thank you,
fabio
