On Tuesday, April 13, 2021 5:16:17 PM CEST Julia Lawall wrote:
> On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> > Removed "ledBlink_param" because it was set to the value of "pbuf" but
> > was never reused. This set was made by direct assignment (no helper
> > had been called), therefore it had no side effect to the location
> > pointed by "pbuf".
> >
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>
> > ---
> >
> > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> > b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index
> > f19a15a3924b..440e22922106 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> > @@ -6191,12 +6191,10 @@ u8 set_chplan_hdl(struct adapter *padapter,
> > unsigned char *pbuf)>
> > u8 led_blink_hdl(struct adapter *padapter, unsigned char *pbuf)
> > {
> >
> > - struct LedBlink_param *ledBlink_param;
> >
> > if (!pbuf)
> >
> > return H2C_PARAMETERS_ERROR;
> >
> > - ledBlink_param = (struct LedBlink_param *)pbuf;
> >
> > return H2C_SUCCESS;
> >
> > }
>
> Is this function actually useful?
>
> julia
>
Actually, it is completely useless.
We should ask the original authors for explanations :)
I'm about to grep the whole driver for the purpose to check if there are
callers elsewhere and then delete any call and the function itself.
Thanks,
Fabio
