On Sat, Apr 10, 2021 at 03:23:35PM +0200, Julia Lawall wrote: > > > On Sat, 10 Apr 2021, Mitali Borkar wrote: > > > Fixed Comparison to NULL can be written as '!...' by replacing it with > > simpler form i.e. boolean expression. This makes code more readable > > alternative. > > Reported by checkpatch. > > > > Signed-off-by: Mitali Borkar <mitaliborkar810@xxxxxxxxx> > > --- > > Changes from v1:- added pointer to the function, which was missed during > > fixing v1. > > > > drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c > > index 4457c1acfbf6..78b5b4eaec5f 100644 > > --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c > > +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c > > @@ -327,7 +327,7 @@ bool GetTs(struct rtllib_device *ieee, struct ts_common_info **ppTS, > > } > > > > *ppTS = SearchAdmitTRStream(ieee, Addr, UP, TxRxSelect); > > - if (ppTS) > > + if (*ppTS) > > This looks like a patch against your previous patch, and not against the > original code. That's fine as I already accepted the previous patch. thanks, greg k-h