On Wed, Apr 07, 2021 at 12:50:36PM +0800, DENG Qingfang wrote: > Add support for MT7530 interrupt controller to handle internal PHYs. > In order to assign an IRQ number to each PHY, the registration of MDIO bus > is also done in this driver. > > Signed-off-by: DENG Qingfang <dqfext@xxxxxxxxx> > --- > RFC v1 -> RFC v2: > - Split MDIO and IRQ setup function Thanks for the split. It looks good. > +/* Forward declaration */ > +struct mt7530_priv; > +static int mt753x_phy_read(struct mii_bus *, int, int); > +static int mt753x_phy_write(struct mii_bus *, int, int, u16); It is better to move the functions to before mt7530_setup_mdio(). Andrew
