On 07/04/2021 18:26, Greg Kroah-Hartman wrote:
On Wed, Apr 07, 2021 at 04:39:25PM +0100, Ian Abbott wrote:
On 07/04/2021 16:10, Greg Kroah-Hartman wrote:
On Wed, Apr 07, 2021 at 03:01:37PM +0100, Ian Abbott wrote:
The code under "drivers/staging/comedi/drivers/tests/" is built when the
CONFIG_COMEDI_TESTS option is enabled. That currently needs to be done
on the "make" command line since the option does not appear in the
Kconfig files.
This patch series fixes a compilation error and various other niggles
including checkpatch.pl stuff.
1) staging: comedi: tests: ni_routes_test: Fix compilation error
2) staging: comedi: tests: ni_routes_test: Put complex values in parentheses
3) staging: comedi: tests: ni_routes_test: Avoid CamelCase: <RVi>
4) staging: comedi: tests: ni_routes_test: Lines should not end with a '('
5) staging: comedi: tests: Correct unittest_fptr
Should we move these to the normal kernel testing directory instead, so
that they do get some build testing?
I'm not sure since they are in "drivers/staging". However, we could add
something to comedi's Kconfig to allow the tests to be built.
We need to get the comedi code out of staging, I really don't think
there is any need to keep it in here anymore, do you? I'll try to carve
some time next week to look at the code and if I can't find anything
left to do, start moving it out.
What do you mean - it's only been in staging for 12 and a half years! :-)
--
-=( Ian Abbott <abbotti@xxxxxxxxx> || MEV Ltd. is a company )=-
-=( registered in England & Wales. Regd. number: 02862268. )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
