On Wed, Apr 7, 2021 at 12:01 PM Ian Abbott <abbotti@xxxxxxxxx> wrote:
>
> Fix a few more issues with the "drivers/staging/comedi/drivers/test/"
> code, including reducing stack usage, declaring more stuff as 'static'
> and adding Kconfig code to allow the unit-test modules to be selected to
> be built individually.
>
> 1) staging: comedi: tests: ni_routes_test: Reduce stack usage
> 2) staging: comedi: tests: ni_route_tests: Declare functions static
> 3) staging: comedi: tests: example_test: Reduce stack usage
> 4) staging: comedi: tests: example_test: Declare functions static
> 5) staging: comedi: tests: example_test: Rename to 'comedi_example_test'
> 6) staging: comedi: Add Kconfig options to build unit test modules
>
> drivers/staging/comedi/Kconfig | 33 ++++++++++++++++++++
> drivers/staging/comedi/drivers/tests/Makefile | 3 +-
> .../{example_test.c => comedi_example_test.c} | 8 ++---
> .../staging/comedi/drivers/tests/ni_routes_test.c | 36 +++++++++++-----------
> 4 files changed, 57 insertions(+), 23 deletions(-)
>
I am not in a position to compile and run the unit test code at the
moment, but otherwise looks good to me.
Reviewed-by: Spencer E. Olson <olsonse@xxxxxxxxx>
