Re: [PATCH 0/5] staging: comedi: tests: Fix various issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 7, 2021 at 8:11 AM Ian Abbott <abbotti@xxxxxxxxx> wrote:
>
> The code under "drivers/staging/comedi/drivers/tests/" is built when the
> CONFIG_COMEDI_TESTS option is enabled.  That currently needs to be done
> on the "make" command line since the option does not appear in the
> Kconfig files.
>
> This patch series fixes a compilation error and various other niggles
> including checkpatch.pl stuff.
>
> 1) staging: comedi: tests: ni_routes_test: Fix compilation error
> 2) staging: comedi: tests: ni_routes_test: Put complex values in parentheses
> 3) staging: comedi: tests: ni_routes_test: Avoid CamelCase: <RVi>
> 4) staging: comedi: tests: ni_routes_test: Lines should not end with a '('
> 5) staging: comedi: tests: Correct unittest_fptr
>
>  .../staging/comedi/drivers/tests/example_test.c    |  2 +-
>  .../staging/comedi/drivers/tests/ni_routes_test.c  | 81 +++++++++++-----------
>  drivers/staging/comedi/drivers/tests/unittest.h    |  2 +-
>  3 files changed, 42 insertions(+), 43 deletions(-)
>

Hmm.  That must have been a fat-finger on my part when I was
submitting those patches.  I am pretty sure that at least one revision
in my copy did have the option comedi/Kconfig at one point.




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux