Hi Mitali, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Mitali-Borkar/staging-rtl8712-fix-avoid-CamelCase-in-xmit_osdep-h/20210407-155925 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git e91cafdf3c18b927e61eb4ee18e4865b8485f24f config: i386-randconfig-a014-20210407 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/9f510deed38aa66173f9ffc8f21c7d61d96f583f git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mitali-Borkar/staging-rtl8712-fix-avoid-CamelCase-in-xmit_osdep-h/20210407-155925 git checkout 9f510deed38aa66173f9ffc8f21c7d61d96f583f # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/staging/rtl8712/xmit_linux.c:94:6: warning: no previous prototype for 'r8712_SetFilter' [-Wmissing-prototypes] 94 | void r8712_SetFilter(struct work_struct *work) | ^~~~~~~~~~~~~~~ vim +/r8712_SetFilter +94 drivers/staging/rtl8712/xmit_linux.c 2865d42c78a912 Larry Finger 2010-08-20 93 f95302eed91061 Ali Bahar 2011-09-04 @94 void r8712_SetFilter(struct work_struct *work) f95302eed91061 Ali Bahar 2011-09-04 95 { 3f35d9022761e4 Nishka Dasgupta 2019-06-07 96 struct _adapter *adapter = container_of(work, struct _adapter, 8810493fc54e75 Deepak Mishra 2019-06-12 97 wk_filter_rx_ff0); f95302eed91061 Ali Bahar 2011-09-04 98 u8 oldvalue = 0x00, newvalue = 0x00; f95302eed91061 Ali Bahar 2011-09-04 99 unsigned long irqL; f95302eed91061 Ali Bahar 2011-09-04 100 3f35d9022761e4 Nishka Dasgupta 2019-06-07 101 oldvalue = r8712_read8(adapter, 0x117); f95302eed91061 Ali Bahar 2011-09-04 102 newvalue = oldvalue & 0xfe; 3f35d9022761e4 Nishka Dasgupta 2019-06-07 103 r8712_write8(adapter, 0x117, newvalue); f95302eed91061 Ali Bahar 2011-09-04 104 6cc6677aee4346 Deepak Mishra 2019-06-12 105 spin_lock_irqsave(&adapter->lock_rx_ff0_filter, irqL); 3f35d9022761e4 Nishka Dasgupta 2019-06-07 106 adapter->blnEnableRxFF0Filter = 1; 6cc6677aee4346 Deepak Mishra 2019-06-12 107 spin_unlock_irqrestore(&adapter->lock_rx_ff0_filter, irqL); f95302eed91061 Ali Bahar 2011-09-04 108 do { f95302eed91061 Ali Bahar 2011-09-04 109 msleep(100); 3f35d9022761e4 Nishka Dasgupta 2019-06-07 110 } while (adapter->blnEnableRxFF0Filter == 1); 3f35d9022761e4 Nishka Dasgupta 2019-06-07 111 r8712_write8(adapter, 0x117, oldvalue); f95302eed91061 Ali Bahar 2011-09-04 112 } f95302eed91061 Ali Bahar 2011-09-04 113 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
