On Tue, Apr 06, 2021 at 11:39:12PM +0800, DENG Qingfang wrote: > On Tue, Apr 6, 2021 at 11:30 PM Andrew Lunn <andrew@xxxxxxx> wrote: > > > > On Tue, Apr 06, 2021 at 10:18:17PM +0800, DENG Qingfang wrote: > > > Add support for MT7530 interrupt controller to handle internal PHYs. > > > > Are the interrupts purely PHY interrupts? Or are there some switch > > operation interrupts, which are currently not used? > > There are other switch operations interrupts as well, such as VLAN > member violation, switch ACL hit. O.K. So that makes it similar to the mv88e6xxx. With that driver, i kept interrupt setup and mdio setup separate. I add the interrupt controller first, and then do mdio setup, calling a helper to map the PHY interrupts and assign them to bus->irq[]. That gives you a cleaner structure when you start using the other interrupts. Andrew
